Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): 💄 improve view mode #55

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat(core): 💄 improve view mode #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/components.registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ import EducationCard from "./components/education/EducationCard";
import ProfileEducationSkeleton from "./components/education/ProfileEducationSkeleton";
import ExperienceCard from "./components/experience/ExperienceCard";
import ProfileExperienceSkeleton from "./components/experience/ProfileExperienceSkeleton";
import ProfileCompletenessCard from "./components/ProfileCompletenessCard";
import UserProfile from "./components/UserProfile";

export const ComponentsRegistry = {
BasicInfoCard : { comp: BasicInfoCard },
ProfileBasicSkeleton : { comp: ProfileBasicSkeleton },
ProfileCompletenessCard : { comp: ProfileCompletenessCard },
ProfileContactSkeleton : { comp: ProfileContactSkeleton },
ProfileEducationSkeleton : { comp: ProfileEducationSkeleton },
ProfileExperienceSkeleton: { comp: ProfileExperienceSkeleton },
Expand Down
3 changes: 2 additions & 1 deletion app/components/UserProfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
CoreBox,
CoreCard,
CoreCardContent,
CoreClasses,
CoreComponent,
CoreDivider,
CoreForm,
Expand Down Expand Up @@ -52,7 +53,7 @@ function UserProfile() {
<>
<CoreLayoutItem id={AppContainerLayout.PLACEHOLDER.CONTENT}>
<CoreGrid>
<CoreCard gridProps={{ gridSize: { sm: 12 } }}>
<CoreCard gridProps={{ gridSize: { sm: 12 } }} styleClasses={[CoreClasses.PADDING.P1]}>
<CoreCardContent>
<CoreGrid coreId="userProfileGrid">
<CoreForm
Expand Down
4 changes: 2 additions & 2 deletions app/components/basicInfo/BasicInfoCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ export default function BasicInfoCard(props) {
const degrees = useSelector((state) => state?.profile?.registration?.degrees);

return (
<CoreGrid styleClasses={[]}>
<CoreGrid styleClasses={[CoreClasses.MARGIN.ML1, CoreClasses.MARGIN.MT_N5]}>
<CoreBox
gridProps={{ gridSize: { md: 2, xs: 12 } }}
gridProps={{ gridSize: { md: 0.9, xs: 12 } }}
styleClasses={[CoreClasses.ALIGNMENT.JUSTIFY_CONTENT_CENTER, CoreClasses.BORDER.BORDER_PRIMARY]}
>
<CoreAvatar
Expand Down
7 changes: 2 additions & 5 deletions app/components/contactInfo/ContactInfoCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,10 @@ export default function ContactInfoCard(props) {
return (
<>
<CoreCardHeader
styleClasses={[CoreClasses.PADDING.P0, CoreClasses.PADDING.PR1]}
title={
<CoreTypographyBody1
styleClasses={[CoreClasses.TEXT.TEXT_WEIGHT_BOLD]}
>
Contact Info
</CoreTypographyBody1>
>Contact Info</CoreTypographyBody1>
}
action={
<CoreIconButton
Expand All @@ -43,7 +40,7 @@ export default function ContactInfoCard(props) {
}
/>

<CoreGrid>
<CoreGrid styleClasses={[CoreClasses.MARGIN.ML1]}>
<CoreBox
gridProps={{ gridSize: { sm: 3 } }}
styleClasses={[CoreClasses.FLEX.DIRECTION_COLUMN]}
Expand Down
36 changes: 19 additions & 17 deletions app/components/education/EducationCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {
CoreTypographyBody1, CoreTypographyBody2, CoreTypographySubtitle2, CoreCardHeader, viewFormattedDate, CoreClasses, CoreStack
CoreTypographyBody1, CoreTypographyBody2, CoreTypographySubtitle2, CoreCardHeader, viewFormattedDate, CoreClasses, CoreStack, CoreGrid
} from "@wrappid/core";

export default function EducationCard(props) {
Expand All @@ -8,23 +8,25 @@ export default function EducationCard(props) {
} = props;

return (
<CoreCardHeader
title={
<CoreTypographyBody1 styleClasses={[CoreClasses.TEXT.TEXT_WEIGHT_BOLD]}>
{degree}
</CoreTypographyBody1>
}
subheader={
<CoreStack>
<CoreTypographySubtitle2>{school}</CoreTypographySubtitle2>
<CoreGrid>
<CoreCardHeader
title={
<CoreTypographyBody1 styleClasses={[CoreClasses.TEXT.TEXT_WEIGHT_BOLD]}>
{degree}
</CoreTypographyBody1>
}
subheader={
<CoreStack>
<CoreTypographySubtitle2>{school}</CoreTypographySubtitle2>

<CoreTypographySubtitle2>{board + ", " + location}</CoreTypographySubtitle2>
<CoreTypographySubtitle2>{board + ", " + location}</CoreTypographySubtitle2>

<CoreTypographyBody2>
{viewFormattedDate(startDate) + " - " + viewFormattedDate(endDate, "endDate")}
</CoreTypographyBody2>
</CoreStack>
}
/>
<CoreTypographyBody2>
{viewFormattedDate(startDate) + " - " + viewFormattedDate(endDate, "endDate")}
</CoreTypographyBody2>
</CoreStack>
}
/>
</CoreGrid>
);
}
Loading