Skip to content

Commit

Permalink
fix(ui): hide CoreProgressBar progression in indeterminate state
Browse files Browse the repository at this point in the history
I forgot to hide the progression when the `CoreProgressBar`'s
progression is `undefined` (which is the case in "indeterminate" state
when no `value` is provided).

So it actually displays `NaN%` when the component settings are `value
=== undefined && displayPercentage === true`. It's better to simply not
display the percentage in this situation.
  • Loading branch information
madeindjs committed Jan 8, 2025
1 parent dc8618b commit 4b7a5d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ui/src/components/core/content/CoreProgressBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
label
}}</label>
<span
v-if="displayPercentage"
v-if="displayPercentage && progression !== undefined"
class="CoreProgressBar__title__progress"
>{{ progressionText }}</span
>
Expand Down

0 comments on commit 4b7a5d8

Please sign in to comment.