-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare UI component handling for enhanced session and CMC integration #258
Merged
ramedina86
merged 7 commits into
writer:dev
from
mmikita95:chore-components-in-event-payload
Mar 1, 2024
Merged
chore: prepare UI component handling for enhanced session and CMC integration #258
ramedina86
merged 7 commits into
writer:dev
from
mmikita95:chore-components-in-event-payload
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egration - Include session-specific component tree in EventResponse payload - Update SessionComponentTree.to_dict to properly merge session-specific and base components, prioritizing session-specific ones - Add optional `flag` attribute to Component class for CMC control - Extend frontend Component type with `flag` property - Implement Component.from_dict class method to enable deserialization - Introduce frontend core logic to update components based on backend session tree data
Been testing this locally, and the only thing I could find are some builder-related glitches – but, as we're making CMCs non-editable this way, it'll be addressed. |
ramedina86
reviewed
Feb 26, 2024
- Renames updateComponents to ingestComponents in ui/core/index.ts - Updates comment and variable name for sendComponent Update - Refactors to_dict method of SessionComponentTree in core.py for readability
BREAKING CHANGE: Pydantic may potentionally interfere with how components are loaded on backend
mmikita95
commented
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flag
attribute to Component class for CMC controlflag
property