Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sub organization applications to issue tokens to access the resources in sub organizations #2616

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Nov 1, 2024

Proposed changes in this pull request

When should this PR be merged

[1] #2578

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from 98ad3c9 to ecb8ca8 Compare November 1, 2024 19:58
@Thumimku
Copy link
Contributor

Hi @ShanChathusanda93,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

@ShanChathusanda93
Copy link
Contributor Author

Hi @ShanChathusanda93,

⚠️ Notice: This PR has been open for a while. To keep the repository clean and up-to-date, this PR will be closed within the next two weeks if there is no further activity.

Please take one of the following actions:

  • Merge the PR if it is ready.
  • Close the PR if it is no longer relevant.
  • Leave a comment explaining why it should remain open and provide an update on its progress.

Your prompt attention to this matter is greatly appreciated. Thank you for your understanding and collaboration! 🙏

This PR is WIP and will be completed withing next couple of days.

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch 4 times, most recently from 08e2154 to 5b0bb86 Compare January 20, 2025 20:20
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from 5b0bb86 to 388a274 Compare January 21, 2025 12:18
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 22.07792% with 120 lines in your changes missing coverage. Please review.

Project coverage is 55.68%. Comparing base (72b70c8) to head (d70822e).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...arbon/identity/oauth2/token/AccessTokenIssuer.java 0.00% 14 Missing ⚠️
...on/identity/oauth2/dao/TokenManagementDAOImpl.java 0.00% 12 Missing ⚠️
...tity/oauth2/validators/TokenValidationHandler.java 7.69% 11 Missing and 1 partial ⚠️
...2/carbon/identity/oauth2/token/JWTTokenIssuer.java 35.29% 7 Missing and 4 partials ⚠️
...th2/token/handlers/grant/PasswordGrantHandler.java 15.38% 10 Missing and 1 partial ⚠️
...dlers/grant/AbstractAuthorizationGrantHandler.java 44.44% 8 Missing and 2 partials ⚠️
...org/wso2/carbon/identity/oauth2/util/JWTUtils.java 0.00% 10 Missing ⚠️
...carbon/identity/oauth2/dao/AccessTokenDAOImpl.java 22.22% 6 Missing and 1 partial ⚠️
...org/wso2/carbon/identity/oauth2/OAuth2Service.java 50.00% 5 Missing and 1 partial ⚠️
...t/authentication/BasicAuthClientAuthenticator.java 40.00% 5 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2616      +/-   ##
============================================
- Coverage     55.94%   55.68%   -0.27%     
+ Complexity     8772     8662     -110     
============================================
  Files           654      654              
  Lines         50916    51035     +119     
  Branches       9985    10163     +178     
============================================
- Hits          28485    28418      -67     
- Misses        18365    18522     +157     
- Partials       4066     4095      +29     
Flag Coverage Δ
unit 39.50% <22.07%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch 4 times, most recently from ff9bac9 to 1148fcb Compare January 22, 2025 13:10
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch 3 times, most recently from 21693aa to cd494b5 Compare January 25, 2025 11:11
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12964547200

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12964547200
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12966633381

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12966633381
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12971096362

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12971096362
Status: failure

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from cd494b5 to 06b64b5 Compare January 26, 2025 07:38
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-app-token-branch branch from 06b64b5 to d70822e Compare January 26, 2025 11:01
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12974134655

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12974134655
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12974134655

@AnuradhaSK
Copy link
Contributor

AnuradhaSK commented Jan 26, 2025

Create a separate issue for unit tests.

Based on integration test pass status and manual testing, approving the PR

@AnuradhaSK AnuradhaSK merged commit f200e60 into wso2-extensions:master Jan 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants