Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token revoke failure in role update flow for sub org. #2663

Merged

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Jan 7, 2025

Purpose

  • $subject

Tested flows

  • Tested the role update flow by removing a role from a user when they already have an access token.
  • Screen recording:
2025-01-07.12-23-58.mp4

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.28%. Comparing base (f1420ad) to head (ab83714).
Report is 22 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2663      +/-   ##
============================================
- Coverage     56.39%   56.28%   -0.12%     
+ Complexity     8273     8234      -39     
============================================
  Files           632      632              
  Lines         46815    46770      -45     
  Branches       8520     8854     +334     
============================================
- Hits          26402    26325      -77     
- Misses        16644    16687      +43     
+ Partials       3769     3758      -11     
Flag Coverage Δ
unit 38.99% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sadilchamishka
sadilchamishka previously approved these changes Jan 8, 2025
@sadilchamishka sadilchamishka dismissed their stale review January 8, 2025 17:26

The token shouldn't be revoked. Hence dismiss the approval

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12705480397

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12705480397
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12705480397

@sadilchamishka sadilchamishka merged commit f2bb062 into wso2-extensions:master Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants