Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save button remains active even when attempting to add an invalid role. #863

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Save button remains active even when attempting to add an invalid role. #863

wants to merge 7 commits into from

Conversation

ShakyaPr
Copy link
Contributor

Purpose

Approach

  • A roleValidity boolean state variable is used to check whether invalid roles exists. If invalid roles exist, then the save button will be disabled

@ShakyaPr ShakyaPr changed the title Save button doesn’t disable when adding an invalid role Save button remains active even when attempting to add an invalid role. Jan 31, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasanthaS lasanthaS Awaiting requested review from lasanthaS lasanthaS is a code owner

@Krishanx92 Krishanx92 Awaiting requested review from Krishanx92 Krishanx92 is a code owner

@tharikaGitHub tharikaGitHub Awaiting requested review from tharikaGitHub tharikaGitHub is a code owner

@piyumaldk piyumaldk Awaiting requested review from piyumaldk piyumaldk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save Button is Active When Adding/Editing Gateway Environment in Admin Portal with Invalid Roles
1 participant
@ShakyaPr