Implement organization support in unified search and fix bugs identified via integration tests #12717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RusJaI
requested review from
tharindu1st,
AnuGayan,
chamilaadhi,
Arshardh,
dushaniw and
tgtshanika
as code owners
chamilaadhi
reviewed
Dec 5, 2024
...carbon.apimgt.persistence/src/main/java/org/wso2/carbon/apimgt/persistence/APIConstants.java
Outdated
Show resolved
Hide resolved
RusJaI
force-pushed
the
org_visibility
branch
2 times, most recently
from
bdca0eb to
134262e
Compare
RusJaI
changed the title
chamilaadhi
reviewed
Dec 16, 2024
| @@ -4200,13 +4225,6 @@ public Map<String, Object> searchPaginatedContent(String searchQuery, String org | |||
| List<APIDefinitionContentSearchResult> defSearchList = new ArrayList<>(); | |||
| int totalLength = 0; | |||
|
|
|||
| String userame = (userNameWithoutChange != null) ? userNameWithoutChange : username; | |||
There was a problem hiding this comment.
do we have to remove this section? maybe we could keep this code unchanged
There was a problem hiding this comment.
That code block is not removed. Instead preserved the previous logic as it is and introduced a separate function for org visibility enabled flow
...gt.persistence/src/main/java/org/wso2/carbon/apimgt/persistence/RegistryPersistenceImpl.java
Outdated
Show resolved
Hide resolved
...t.persistence/src/main/java/org/wso2/carbon/apimgt/persistence/utils/RegistrySearchUtil.java
Outdated
Show resolved
Hide resolved
chamilaadhi
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wso2/api-manager#3406