Restrict modifying configurations for Enterprise IDP Login Applications

wso2 · May 10, 2022 · c826a8d · c826a8d
1 parent ac14cdc
commit c826a8d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 4 deletions.
diff --git a/apps/console/src/extensions/configs/application.tsx b/apps/console/src/extensions/configs/application.tsx
@@ -64,7 +64,16 @@ export const applicationConfig: ApplicationConfig = {
         renderHelpPanelItems: (): ReactNode => {
             return null;
         },
-        showProvisioningSettings: true
+        showProvisioningSettings: true,
+        showDangerZone: (applicationName: string): boolean => {
+            return true;
+        },
+        showDeleteButton: (applicationName: string): boolean => {
+            return true;
+        },
+        getTabPanelReadOnlyStatus: (tabPanelName: string, applicationName: string): boolean => {
+            return false;
+        }
     },
     excludeIdentityClaims: false,
     excludeSubjectClaim: false,

diff --git a/apps/console/src/extensions/configs/models/application.ts b/apps/console/src/extensions/configs/models/application.ts
@@ -53,6 +53,9 @@ export interface ApplicationConfig {
         extendTabs: boolean; //should be true for cloud
         showProvisioningSettings: boolean;
         renderHelpPanelItems: () => ReactNode;
+        showDangerZone: (applicationName: string) => boolean;
+        showDeleteButton: (applicationName: string) => boolean;
+        getTabPanelReadOnlyStatus: (tabPanelName: string, applicationName: string) => boolean;
     };
     inboundOIDCForm: {
         shouldValidateCertificate: boolean;

diff --git a/apps/console/src/features/applications/components/application-list.tsx b/apps/console/src/features/applications/components/application-list.tsx
@@ -61,6 +61,7 @@ import {
     ApplicationTemplateListItemInterface
 } from "../models";
 import { ApplicationTemplateManagementUtils } from "../utils";
+import { applicationConfig } from "../../../extensions";
 
 /**
  *
@@ -380,7 +381,8 @@ export const ApplicationList: FunctionComponent<ApplicationListPropsInterface> =
 
                     return hasScopes ||
                             isSystemApp ||
-                            (app?.access === ApplicationAccessTypes.READ);
+                            (app?.access === ApplicationAccessTypes.READ) ||
+                            !applicationConfig.editApplication.showDeleteButton(app.name);
                 },
                 icon: (): SemanticICONS => "trash alternate",
                 onClick: (e: SyntheticEvent, app: ApplicationListItemInterface): void => {

diff --git a/apps/console/src/features/applications/components/edit-application.tsx b/apps/console/src/features/applications/components/edit-application.tsx
@@ -591,7 +591,8 @@ export const EditApplication: FunctionComponent<EditApplicationPropsInterface> =
                 onUpdate={ handleApplicationUpdate }
                 featureConfig={ featureConfig }
                 template={ template }
-                readOnly={ readOnly }
+                readOnly={ readOnly || applicationConfig.editApplication.getTabPanelReadOnlyStatus(
+                                "APPLICATION_EDIT_GENERAL_SETTINGS", application.name) }
                 data-testid={ `${ testId }-general-settings` }
                 isManagementApp={ application.isManagementApp }
             />
@@ -620,7 +621,8 @@ export const EditApplication: FunctionComponent<EditApplicationPropsInterface> =
                 inboundProtocols={ inboundProtocolList }
                 featureConfig={ featureConfig }
                 template={ template }
-                readOnly={ readOnly }
+                readOnly={ readOnly || applicationConfig.editApplication.getTabPanelReadOnlyStatus(
+                                "APPLICATION_EDIT_ACCESS_CONFIG", application.name) }
                 data-testid={ `${ testId }-access-settings` }
             />
         </ResourceTab.Pane>

diff --git a/apps/console/src/features/applications/components/settings/general-application-settings.tsx b/apps/console/src/features/applications/components/settings/general-application-settings.tsx
@@ -37,6 +37,7 @@ import {
     ApplicationTemplateListItemInterface
 } from "../../models";
 import { GeneralDetailsForm } from "../forms";
+import { applicationConfig } from "../../../../extensions";
 
 /**
  * Proptypes for the applications general details component.
@@ -237,6 +238,10 @@ export const GeneralApplicationSettings: FunctionComponent<GeneralApplicationSet
             return null;
         }
 
+        if (!applicationConfig.editApplication.showDangerZone(name)) {
+            return null;
+        }
+
         if (hasRequiredScopes(
             featureConfig?.applications, featureConfig?.applications?.scopes?.delete, allowedScopes)) {
             return (