Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maintaiance] Change Switcher components by RadioGroups to avoid confusions about expected behaviors #4295

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[maintaiance] Change Switcher components by RadioGroups to avoid confusions about expected behaviors #4295

wants to merge 2 commits into from

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Oct 23, 2023 •
edited
Loading

Purpose

Replacing <Switcher> components with vanilla <RadioGroup> components to improve the user experience and avoid confusion about the expected behavior.

Affected flows:

  • Create Trusted Token Issuer Connection:

    wizard-token-issuer

  • Create OIDC Standard-Based IdP Connection:

    wizard-idp-oidc

  • Create SAML Standard-Based IdP Connection:

    wizard-idp-saml

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@brionmario brionmario changed the title Change Switcher components by RadioGroups to avoid confusions about expected behaviors [unification] Change Switcher components by RadioGroups to avoid confusions about expected behaviors Oct 25, 2023
@brionmario brionmario mentioned this pull request Nov 21, 2023
Closed
@brionmario
Copy link
Member Author

brionmario commented Nov 21, 2023 •
edited
Loading

This can hold until RC1 is Released.

@brionmario brionmario changed the title [unification] Change Switcher components by RadioGroups to avoid confusions about expected behaviors [maintaiance] Change Switcher components by RadioGroups to avoid confusions about expected behaviors Nov 30, 2023
@brionmario brionmario marked this pull request as draft November 30, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brionmario