Add UI support for Push notification based authentication #7370

ZiyamSanthosh · 2025-01-23T09:34:40Z

Purpose

This PR introduces the components required to enable push notification based authentication.

Related Issues

N/A

Related PRs

N/A

Checklist

e2e cypress tests locally verified. (for internal contributers)
Manual test round performed and verified.
UX/UI review done on the final implementation.
Documentation provided. (Add links if there are any)
Relevant backend changes deployed and verified
Unit tests provided. (Add links if there are any)
Integration tests provided. (Add links if there are any)

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines
Ran FindSecurityBugs plugin and verified report
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets

pavinduLakshan · 2025-01-23T09:51:12Z

apps/console/src/configs/routes.tsx

@@ -739,9 +739,9 @@ export const getAppViewRoutes = (): RouteInterface[] => {
            exact: true,
            icon: { icon: <EnvelopeGearIcon fill="black" className="icon" /> },
            id: "notificationChannels",
-            name: "Email & SMS",
+            name: "Notification Channels",


Let's use i18n for string literals

pavinduLakshan · 2025-01-23T09:51:37Z

apps/console/src/configs/routes.tsx

+                icon: getSidePanelIcons().sms
+            },
+            id: "pushProviders",
+            name: "Push",


Is this name intentional?

apps/console/src/public/deployment.config.json

apps/console/src/public/resources/notification-providers/assets/images/illustrations/push.svg

pavinduLakshan · 2025-01-23T09:55:01Z

apps/console/webpack.config.ts

Let's revert this change when the PR is ready to merge

pavinduLakshan · 2025-01-23T10:11:34Z

identity-apps-core/apps/authentication-portal/src/main/webapp/images/pushAuth.png

Where do we show this image in the auth portal

pavinduLakshan · 2025-01-23T10:11:58Z

features/admin.template-core.v1/models/dynamic-fields.ts

@@ -30,6 +30,13 @@ export interface DynamicFormInterface {
     * Should the form only submit the fields defined above.
     */
    submitDefinedFieldsOnly?: boolean;
+
+    common: DynamicCommonInterface;


add missing doc comment

features/admin.push-providers.v1/tsconfig.json

features/admin.push-providers.v1/rollup.config.cjs

pavinduLakshan · 2025-01-23T10:13:28Z

features/admin.push-providers.v1/pages/push-providers.tsx

+    };
+
+    const handlePushProviderUpdate = ( data: PushProviderAPIInterface ): void => {
+        // TODO: Implement update API call.


Let's update the missing function body

wso2-jenkins-bot · 2025-01-23T10:20:17Z

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

wso2-jenkins-bot · 2025-01-23T10:20:17Z

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

pavinduLakshan · 2025-01-23T15:44:50Z

apps/console/src/extensions/i18n/resources/en-US/extensions.ts

+                quickStart: {
+                    addLoginModal: {
+                        heading: "Add Push Authenticator",
+                        subHeading: "Select an application to set up Push Authentication login."


Suggested change

subHeading: "Select an application to set up Push Authentication login."

subHeading: "Select an application to set up push authentication."

pavinduLakshan · 2025-01-23T15:45:08Z

apps/console/src/extensions/i18n/resources/en-US/extensions.ts

+                    },
+                    connectApp: {
+                        description:
+                            "Add <1>Push NotificationP</1> to <3>Step 2</3> on the <5>Login Flow" +


Suggested change

"Add <1>Push NotificationP</1> to <3>Step 2</3> on the <5>Login Flow" +

"Add <1>Push Notification</1> to <3>Step 2</3> on the <5>Login Flow" +

pavinduLakshan · 2025-01-23T15:45:54Z

apps/console/src/extensions/i18n/resources/en-US/extensions.ts

+                            "</5> section of your <7>application</7>."
+                    },
+                    heading: "Push Authenticator Set Up Guide",
+                    subHeading: "Follow the instructions given below to set up Push Authenticator as a factor in your login flow.",


Suggested change

subHeading: "Follow the instructions given below to set up Push Authenticator as a factor in your login flow.",

subHeading: "Follow the instructions to set up Push Authenticator in your login flow.",

pavinduLakshan · 2025-01-23T15:46:21Z

apps/console/src/extensions/i18n/resources/en-US/extensions.ts

+                    subHeading: "Follow the instructions given below to set up Push Authenticator as a factor in your login flow.",
+                    steps: {
+                        selectApplication: {
+                            content: "Choose the <1>application</1> for which you want to set up Push Authenticator login.",


Suggested change

content: "Choose the <1>application</1> for which you want to set up Push Authenticator login.",

content: "Choose the <1>application</1> for which you want to set up Push Authentication.",

features/admin.connections.v1/components/authenticators/push/quick-start.tsx

features/admin.connections.v1/resources/assets/images/icons/push.svg

features/admin.push-providers.v1/components/push-provider-card.tsx

features/admin.connections.v1/components/edit/forms/authenticators/push-authenticator-form.tsx

features/admin.core.v1/configs/app.ts

...ures/admin.identity-providers.v1/components/forms/authenticators/push-authenticator-form.tsx

…s/images/illustrations/push.svg

…uick-start.tsx

pavinduLakshan · 2025-01-23T17:28:05Z

features/admin.connections.v1/components/authenticator-grid.tsx

@@ -157,7 +158,10 @@ export const AuthenticatorGrid: FunctionComponent<AuthenticatorGridPropsInterfac
    const dispatch: Dispatch = useDispatch();
    const eventPublisher: EventPublisher = EventPublisher.getInstance();
    const { UIConfig } = useUIConfig();
+    const hiddenAuthenticators: string[] = [ ...(UIConfig?.hiddenAuthenticators ?? []) ];


You can hide the authenticators by specifying authenticator names in hiddenAuthenticators in deployment.config.json.

@ZiyamSanthosh

apps/console/package.json

…pushAuthError.jsp

features/admin.core.v1/constants/app-constants.ts

features/admin.core.v1/package.json

features/admin.push-providers.v1/api/push-provider.ts

features/admin.push-providers.v1/api/use-create-push-provider.ts

features/admin.push-providers.v1/api/push-provider.ts

…ider-icon.svg

features/admin.push-providers.v1/api/push-provider.ts

…tors/push-authenticator-form.tsx

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.connections.v1/components/authenticators/push/quick-start.tsx Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.connections.v1/components/authenticators/push/quick-start.tsx Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.connections.v1/resources/assets/images/icons/push.svg Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.push-providers.v1/components/push-provider-card.tsx Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.connections.v1/components/edit/forms/authenticators/push-authenticator-form.tsx Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.connections.v1/components/edit/forms/authenticators/push-authenticator-form.tsx Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.core.v1/configs/app.ts Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

...ures/admin.identity-providers.v1/components/forms/authenticators/push-authenticator-form.tsx Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

...ures/admin.identity-providers.v1/components/forms/authenticators/push-authenticator-form.tsx Outdated Show resolved Hide resolved

ZiyamSanthosh and others added 17 commits January 23, 2025 21:39

Add jsp pages for push based authentication

f90331d

Add i18n for push authentication jsp pages

ff6f9cd

Add UI support for push authentication

cfdad0e

Update apps/console/src/public/deployment.config.json

b75356d

Update apps/console/src/public/resources/notification-providers/asset…

470abd8

…s/images/illustrations/push.svg

Update features/admin.connections.v1/components/authenticators/push/q…

ca53ab7

…uick-start.tsx

Update features/admin.push-providers.v1/tsconfig.json

7a9b8ee

Update features/admin.connections.v1/components/authenticators/push/q…

3a703ac

…uick-start.tsx

Update features/admin.push-providers.v1/rollup.config.cjs

96e89b8

Update features/admin.connections.v1/components/authenticators/push/q…

f6f1d7e

…uick-start.tsx

Update features/admin.connections.v1/components/authenticators/push/q…

514f184

…uick-start.tsx

Update modules/i18n/src/translations/en-US/portals/push-providers.ts

47fccc7

Discard changes to apps/console/webpack.config.ts

d40596e

Update features/admin.connections.v1/components/authenticators/push/q…

7bca222

…uick-start.tsx

Update features/admin.connections.v1/components/authenticators/push/q…

a604fc2

…uick-start.tsx

Update features/admin.connections.v1/components/authenticators/push/q…

9c6e616

…uick-start.tsx

Update features/admin.connections.v1/components/authenticators/push/q…

c372b9e

…uick-start.tsx

Fix syntax issues

0cc13c3

pavinduLakshan force-pushed the master-push-jsp branch from 5aedac5 to 0cc13c3 Compare January 23, 2025 17:25

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

pavinduLakshan added 2 commits January 23, 2025 23:01

Update modules/i18n/src/translations/en-US/portals/push-providers.ts

846607a

Delete unnecessary changelog

6f141bb

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

apps/console/package.json Outdated Show resolved Hide resolved

pavinduLakshan added 2 commits January 23, 2025 23:04

Update apps/console/package.json

f820855

Update identity-apps-core/apps/authentication-portal/src/main/webapp/…

c0788b5

…pushAuthError.jsp

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.core.v1/constants/app-constants.ts Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.core.v1/package.json Outdated Show resolved Hide resolved

Update features/admin.core.v1/package.json

fa38fd0

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.push-providers.v1/api/push-provider.ts Outdated Show resolved Hide resolved

Update features/admin.push-providers.v1/api/push-provider.ts

0be1e16

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.push-providers.v1/api/push-provider.ts Outdated Show resolved Hide resolved

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.push-providers.v1/api/push-provider.ts Outdated Show resolved Hide resolved

pavinduLakshan added 2 commits January 23, 2025 23:11

Update features/admin.push-providers.v1/api/push-provider.ts

939350e

Update features/admin.push-providers.v1/api/push-provider.ts

04afe0b

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.push-providers.v1/api/use-create-push-provider.ts Outdated Show resolved Hide resolved

pavinduLakshan added 3 commits January 23, 2025 23:14

Update features/admin.push-providers.v1/api/use-create-push-provider.ts

83e6481

Update features/admin.core.v1/constants/app-constants.ts

b534970

Fix spelling issues

ba0dc4a

pavinduLakshan reviewed Jan 23, 2025

View reviewed changes

features/admin.push-providers.v1/api/push-provider.ts Outdated Show resolved Hide resolved

pavinduLakshan added 5 commits January 23, 2025 23:17

Update features/admin.push-providers.v1/api/push-provider.ts

7cf01ca

Remove unused images

278551d

Add missing i18n for push authentication

e6dffe8

Update modules/theme/src/themes/default/assets/images/icons/push.svg

48c18e4

Update modules/theme/src/themes/default/assets/images/icons/push-prov…

01d6af1

…ider-icon.svg

pavinduLakshan reviewed Jan 24, 2025

View reviewed changes

features/admin.push-providers.v1/api/push-provider.ts Outdated Show resolved Hide resolved

pavinduLakshan added 2 commits January 24, 2025 11:11

Update features/admin.push-providers.v1/api/push-provider.ts

027a4a3

Update features/admin.connections.v1/components/edit/forms/authentica…

c663420

…tors/push-authenticator-form.tsx

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add UI support for Push notification based authentication #7370

Add UI support for Push notification based authentication #7370

ZiyamSanthosh commented Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

wso2-jenkins-bot commented Jan 23, 2025

wso2-jenkins-bot commented Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

pavinduLakshan Jan 23, 2025

	subHeading: "Select an application to set up Push Authentication login."
	subHeading: "Select an application to set up push authentication."

	"Add <1>Push NotificationP</1> to <3>Step 2</3> on the <5>Login Flow" +
	"Add <1>Push Notification</1> to <3>Step 2</3> on the <5>Login Flow" +

	subHeading: "Follow the instructions given below to set up Push Authenticator as a factor in your login flow.",
	subHeading: "Follow the instructions to set up Push Authenticator in your login flow.",

	content: "Choose the <1>application</1> for which you want to set up Push Authenticator login.",
	content: "Choose the <1>application</1> for which you want to set up Push Authentication.",

Add UI support for Push notification based authentication #7370

Are you sure you want to change the base?

Add UI support for Push notification based authentication #7370

Conversation

ZiyamSanthosh commented Jan 23, 2025

Purpose

Related Issues

Related PRs

Checklist

Security checks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wso2-jenkins-bot commented Jan 23, 2025

⚠️ No Changeset found

wso2-jenkins-bot commented Jan 23, 2025

⚠️ No Changeset found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment