Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode the encoded url lang input before splitting #7437

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

mpmadhavig
Copy link
Contributor

Purpose

As issue has occurred when multiple languages are set as the ui_lang query param, the first item doesn't get picked up when setting ui_lang cookie.

The root cause was we have encoded the url query param before processing it [1].

With this fix, we decode the encoded query param value before making the split operation.

[1] #4826

kayathiri4
kayathiri4 previously approved these changes Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.98%. Comparing base (771f628) to head (7c847ad).
Report is 526 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7437      +/-   ##
==========================================
+ Coverage   36.53%   41.98%   +5.45%     
==========================================
  Files          42       42              
  Lines         906      936      +30     
  Branches      223      233      +10     
==========================================
+ Hits          331      393      +62     
+ Misses        555      524      -31     
+ Partials       20       19       -1     
Flag Coverage Δ
@wso2is/core 41.98% <ø> (+5.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@mpmadhavig mpmadhavig merged commit 1d1a023 into wso2:master Jan 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants