Add predefined flows for push authenticator #7440
Conversation
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7440 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 42 42
Lines 936 936
Branches 233 227 -6
=======================================
Hits 393 393
+ Misses 524 499 -25
- Partials 19 44 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -96,6 +96,7 @@ export const getAuthenticatorIcons = (): any => { | |||
| microsoft: MicrosoftLogo, | |||
| office365: Office365Logo, | |||
| push: PushIcon, | |||
| "push-notification-authenticator": PushIcon, | |||
There was a problem hiding this comment.
Cannot we reuse the icon defined in L98?
| @@ -19,3 +19,4 @@ | |||
| export { default as EmailOTPSecondFactorLoginSequence } from "./second-factor-email-otp-sequence.json"; | |||
| export { default as SMSOTPSecondFactorLoginSequence } from "./second-factor-sms-otp-sequence.json"; | |||
| export { default as TOTPSecondFactorLoginSequence } from "./second-factor-totp-sequence.json"; | |||
| export { default as PushAuthSecondFactorLoginSequence } from "./second-factor-push-auth-sequence.json"; | |||
There was a problem hiding this comment.
Have we made sure that this can be enabled/disabled conditionally in console UI?
| @@ -17,7 +17,7 @@ | |||
| */ | |||
|
|
|||
| :root { | |||
| --asg-auth-flow-builder-side-panel-drawer-width: 450px; | |||
| --asg-auth-flow-builder-side-panel-drawer-width: 480px; | |||
There was a problem hiding this comment.
Shall we add a screenshot of the UI with this change?
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
This will enable push auth login sequence in visual editor, but may not show it in the classic editor (which is disabled in IS, but still enabled in Asgardeo).
Therefore, we may need to updated the classic editor quickstart as well.
This PR will add the predefined flows relevant to Push Notification Based Authenticators.