-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce branding support for push authentication screen #7509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7509 +/- ##
=======================================
Coverage 41.98% 41.98%
=======================================
Files 42 42
Lines 936 936
Branches 233 227 -6
=======================================
Hits 393 393
Misses 499 499
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. |
pavinduLakshan
commented
Feb 5, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
pavinduLakshan
commented
Feb 5, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
pavinduLakshan
commented
Feb 5, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
pavinduLakshan
commented
Feb 5, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
pavinduLakshan
commented
Feb 5, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
pavinduLakshan
commented
Feb 5, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Feb 6, 2025
features/admin.branding.v1/components/preview/sign-in-box/fragments/push-auth-fragment.tsx
Outdated
Show resolved
Hide resolved
…ments/push-auth-fragment.tsx
7d2b664
to
a0c8ecf
Compare
brionmario
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks