Skip to content

Commit

Permalink
Merge pull request #134 from savindi7/chore-update-icons
Browse files Browse the repository at this point in the history
feat(primitives): update icons and designing guidelines
  • Loading branch information
savindi7 authored Jun 14, 2023
2 parents edb23b1 + 750cfc6 commit 9b2d9a7
Show file tree
Hide file tree
Showing 68 changed files with 608 additions and 428 deletions.
35 changes: 29 additions & 6 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ The `footer` is optional. The [Commit Message Footer](#commit-footer) format des
│ │
│ └─⫸ Commit Scope: primitives|scss|react
└─⫸ Commit Type: build|ci|docs|feat|fix|perf|refactor|test
└─⫸ Commit Type: build|ci|docs|feat|fix|perf|refactor|chore|test
```
The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is optional.
Expand All @@ -180,6 +180,7 @@ Must be one of the following:
* **fix**: A bug fix
* **perf**: A code change that improves performance
* **refactor**: A code change that neither fixes a bug nor adds a feature
* **chore**: Housekeeping tasks that doesn't require to be highlighted in the changelog
* **test**: Adding missing tests or correcting existing tests
Expand Down Expand Up @@ -210,9 +211,9 @@ There are currently a few exceptions to the "use package name" rule:
Use the summary field to provide a succinct description of the change:
* use the imperative, present tense: "change" not "changed" nor "changes"
* don't capitalize the first letter
* no dot (.) at the end
* Use the imperative, present tense: "change" not "changed" nor "changes".
* Don't capitalize the first letter.
* No dot (.) at the end.
#### <a name="commit-body"></a>Commit Message Body
Expand Down Expand Up @@ -259,8 +260,8 @@ If the commit reverts a previous commit, it should begin with `revert: `, follow
The content of the commit message body should contain:
- information about the SHA of the commit being reverted in the following format: `This reverts commit <SHA>`,
- a clear description of the reason for reverting the commit message.
- Information about the SHA of the commit being reverted in the following format: `This reverts commit <SHA>`.
- A clear description of the reason for reverting the commit message.
## Designing
Expand Down Expand Up @@ -297,6 +298,28 @@ Following diagram illustrates the design tokens workflow.

<img src="./docs/resources/images/architecture/oxygen-ui-tokens-process.png" width="800" />

### Designing Icons

When designing SVG icons for the `Primitives` package, follow these guidelines:

- Use general names for icons, do not use scenario specific names.

✅ Do

_envelop-outlined-16.svg_

❌ Don't

_email-input-icon.svg_
- Use fill rather than stroke.
- Use consistent colors.
- Use consistent line widths.
- Name the files in the following format.

_<icon_name>-<icon_variation>-<size>.svg_

_example: home-filled-16.svg_

## Versioning

For details on the project's versioning policy, please refer to the [VERSIONING_POLICY.md](VERSIONING_POLICY.md) document. It is recommended to read this document before carrying out any versioning-related tasks.
21 changes: 21 additions & 0 deletions packages/primitives/src/icons/arrow-left-arrow-right-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions packages/primitives/src/icons/arrow-right-from-bracket-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions packages/primitives/src/icons/arrow-right-to-bracket-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions packages/primitives/src/icons/arrow-up-right-from-square-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions packages/primitives/src/icons/briefcase-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions packages/primitives/src/icons/briefcase-building-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 0 additions & 30 deletions packages/primitives/src/icons/cache-16.svg

This file was deleted.

22 changes: 22 additions & 0 deletions packages/primitives/src/icons/camera-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 9b2d9a7

Please sign in to comment.