Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): add Arrow icons, change CopyIcon, EyeIcon and EyeSlashIcon #255

Merged
merged 16 commits into from
Sep 5, 2024

Conversation

Achintha444
Copy link
Contributor

@Achintha444 Achintha444 commented Sep 4, 2024

Purpose

feat(primitives): add Arrow icons and change PlusIcon

Related Issues

Checklist

  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@Achintha444 Achintha444 requested a review from savindi7 September 4, 2024 10:38
@savindi7
Copy link
Contributor

savindi7 commented Sep 4, 2024

We are following the guideline of adding icons with the line height as 1px. shall we make it consistent.

savindi7
savindi7 previously approved these changes Sep 4, 2024
savindi7
savindi7 previously approved these changes Sep 4, 2024
@Achintha444 Achintha444 changed the title feat(primitives): add Arrow icons and change PlusIcon feat(primitives): add Arrow icons, change CopyIcon, EyeIcon and EyeSlashIcon Sep 4, 2024
@Achintha444 Achintha444 merged commit 267386c into wso2:main Sep 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants