feat(react): add CircularProgressAvatar component
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
reviewed
Feb 15, 2023
packages/react/src/components/CircularProgressAvatar/CircularProgressAvatar.tsx
Show resolved
Hide resolved
brionmario
reviewed
Feb 15, 2023
| * under the License. | ||
| */ | ||
|
|
||
| import {Badge, BadgeProps, CircularProgress, CircularProgressProps} from '@mui/material'; |
There was a problem hiding this comment.
Wrap these components. Even if not wrapped, always better to use the tree shakable import syntax.
https://mui.com/material-ui/guides/minimizing-bundle-size/#option-one-use-path-imports
There was a problem hiding this comment.
Got it. Will wrap and do this improvement in commits seperately.
brionmario
reviewed
Feb 15, 2023
packages/react/src/components/CircularProgressAvatar/CircularProgressAvatar.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Feb 15, 2023
packages/react/src/components/CircularProgressAvatar/CircularProgressAvatar.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Feb 15, 2023
packages/react/src/components/CircularProgressAvatar/CircularProgressAvatar.tsx
Outdated
Show resolved
Hide resolved
brionmario
reviewed
Feb 15, 2023
brionmario
previously approved these changes
Feb 15, 2023
savindi7
changed the title
ProfileOverview componentCircularProgressAvatar component
…-1 into feat-profile-overview
…-1 into feat-profile-overview
thivi
approved these changes
Feb 15, 2023
Comment on lines
+28
to
+35
| args={{color: 'warning', | ||
| progress: 70, | ||
| badgeOptions: {color: 'primary', badgeContent: '70%'}, | ||
| avatarOptions: { | ||
| src: '/assets/images/avatar-john.svg', | ||
| alt:'avatar', | ||
| } | ||
| }} |
There was a problem hiding this comment.
Can we move colors to the next line to make it more readable?
There was a problem hiding this comment.
Ack. Will send a seperate PR for this improvement.
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the following component.
CircularProgressAvatarRelated Issues
Related PRs
Checklist
Security checks