feat(react): add Select component
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
reviewed
Mar 8, 2023
| import InputLabel, {InputLabelProps as MuiInputLabelProps} from '../InputLabel'; | ||
| import './select.scss'; | ||
|
|
||
| export interface SelectProps extends MuiSelectProps { |
There was a problem hiding this comment.
Is this component polymorphic?
There was a problem hiding this comment.
There is no component prop to make this component take the form of a different Component element.
brionmario
approved these changes
Mar 9, 2023
thivi
approved these changes
Mar 9, 2023
| import './select.scss'; | ||
|
|
||
| export interface SelectProps extends MuiSelectProps { | ||
| InputLabelProps?: MuiInputLabelProps; |
There was a problem hiding this comment.
Are we making this prop optional here?
There was a problem hiding this comment.
yes. the props already passed satisfies the basic functionality
73 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
Selectcomponent.Related Issues
Related PRs
Checklist
Security checks