Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username recovery integration tests. #22461

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Add username recovery integration tests. #22461

merged 9 commits into from
Jan 28, 2025

Conversation

Malith-19
Copy link
Contributor

@Malith-19 Malith-19 commented Jan 26, 2025 •
edited
Loading

Purpose

  • $subject

Related issues

Covered scenarios

  • Username recovery with only sms channel enabled.
  • Only email channel enabled.
  • Both channels enabled, and for each channel.
  • Non unique user support config enabled.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12974917255

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12974917255
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12982170540

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12982170540
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12988471029

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12988471029
Status: failure

@Malith-19 Malith-19 changed the title Add username recovery tests. Add username recovery integration tests. Jan 27, 2025
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13006276903

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13006276903
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13006276903

sahandilshan
sahandilshan previously approved these changes Jan 28, 2025
View reviewed changes
...kend/src/test/java/org/wso2/identity/integration/test/recovery/UsernameRecoveryTestCase.java Outdated
*/
public class UsernameRecoveryTestCase extends OIDCAbstractIntegrationTest {

// Constants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Constants
// Constants.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 1f00b05

...kend/src/test/java/org/wso2/identity/integration/test/recovery/UsernameRecoveryTestCase.java Outdated Show resolved Hide resolved
@sahandilshan sahandilshan merged commit 6cfc244 into wso2:master Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@sahandilshan sahandilshan sahandilshan approved these changes

@madurangasiriwardena madurangasiriwardena Awaiting requested review from madurangasiriwardena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Malith-19 @jenkins-is-staging @sahandilshan