-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sidebar and FASTA ID wrapping #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, just one change request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, thanks Elvin.
@djleite would you like to test to confirm this fixes the issue you've raised?
@3lviend - thank you. I see two issues still
https://www.loom.com/share/49ebf76b3ffe44899272c6fdb653f03b?sid=a2738378-f7b2-4e0e-84e7-b14171e29a43 |
Download links are disabled when you query against database that was formatted without parse_seqids, I did a test with a correctly formatted DB and the links show up. Shout if that's not right @djleite |
6e6168c
to
bfa7fda
Compare
issue #802
Sidebar option selected
Share results