Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update python to python3 in myph.sh #167

Closed
wants to merge 3 commits into from
Closed

Conversation

wuwentao
Copy link
Owner

PR Description

mypy.....................................................................Failed
- hook id: mypy
- exit code: 127

scripts/mypy.sh: line 7: python: command not found

Reason & Detail

Related issue

fix #X

@chemelli74
Copy link
Collaborator

Again something strange, python should be a symlink to the latest python available in the system

Copy link
Collaborator

@chemelli74 chemelli74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #170 , is that still needed ?

@wuwentao
Copy link
Owner Author

Again something strange, python should be a symlink to the latest python available in the system

just for discussion:
most of the os don't have python symlink to python3, for example: ubuntu/debian/macos
as default python is python2 in old os and only use python3.

@chemelli74
Copy link
Collaborator

Again something strange, python should be a symlink to the latest python available in the system

just for discussion: most of the os don't have python symlink to python3, for example: ubuntu/debian/macos as default python is python2 in old os and only use python3.

The correct way is sudo apt install python-is-python3 - it effectively does a symlink, but it also keeps pace with future updates; so if your ubuntu distribution moves to say Python 3.9, the manual symlink will no longer work, but the package makes sure it is still valid.

@wuwentao wuwentao closed this Jun 25, 2024
@chemelli74 chemelli74 deleted the update_mypy_sh branch June 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants