-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using gulp-dart-sass to compile Sass #273
Comments
Got some time to try this out in a project based off of the design system this morning. Found one blocking error that prevents https://github.com/wvuweb/wvu-design-system/blob/master/scss/utilities/_wvu-slash.scss#L78 For some reason this @for $i from 1 through 5 {
.wvu-slash {
...
}
} ☝️ I will open a separate issue to document this change. |
I've been using One thing I did notice is gulp-dart-sass doesn't have issues enabled for that repository. For this reason I am now leaning more towards |
Learned that Sass is deprecating |
Continuing to drop helpful resources in this thread about Dart Sass: Zell Liew wrote an article about how to use Gulp v4 with Dart Sass. |
…ward compatibility. If you use Dart Sass to compile the Design System's Sass files, Dart Sass throws depreciation warnings about the `/` symbol. They advise us to use a new `math.div()` function or `calc()` to solve these warnings. Since we're not doing any hard math, simple multiplication seems like the best fix. Related to #273.
…ward compatibility. If you use Dart Sass to compile the Design System's Sass files, Dart Sass throws depreciation warnings about the `/` symbol. They advise us to use a new `math.div()` function or `calc()` to solve these warnings. Since we're not doing any hard math, simple multiplication seems like the best fix. Related to #273.
What's going on right now
The Design System currently uses gulp-sass to compile Sass files. Gulp-sass, by default, uses node-sass/libsass by default. According to the maintainer of Sass, people should use Dart Sass (the official compiler) instead of Node Sass/Libsass.
https://github.com/mattdsteele/gulp-dart-sass
Results
Right now everything works as expected; however, we cannot guarantee this forever.
Expected results
Moving to
gulp-dart-sass
course-corrects any future errors we might see from Sass/CSS syntax updates.What to do now
Before moving to
gulp-dart-sass
, we should test this package to make sure everything works as expected.I should also note: the
gulp-sass
package has the ability to specify a compiler--dart-sass is one of those options.The text was updated successfully, but these errors were encountered: