Replace Sass division symbol (/) with multiplication for better forward compatibility
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ward compatibility. If you use Dart Sass to compile the Design System's Sass files, Dart Sass throws depreciation warnings about the `/` symbol. They advise us to use a new `math.div()` function or `calc()` to solve these warnings. Since we're not doing any hard math, simple multiplication seems like the best fix. Related to #273.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use Dart Sass to compile the Design System's Sass files, Dart Sass throws depreciation warnings about the
/symbol. They advise us to use a newmath.div()function orcalc()to solve these warnings. Since we're not doing any hard math, simple multiplication seems like the best fix.This change doesn't change any actual CSS, just the Sass. It should be good to merge.
Related to #273.
Also, Bootstrap used the
/symbol up until v4.6.1. So, if you're looking to use Dart Sass with Bootstrap, it'd be a good idea to pull in the latest version of Bootstrap. FWIW, I use the latest version of Bootstrap v4.x.x on all my projects and have noticed zero regressions.If there is no activity on this PR by 4/1/22, I will merge this PR myself.