-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Import entrypoint improvements #1207
Conversation
… to reduce number of event listeners
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wouldn't this also massively speed up build times? |
It would speed up importing the entrypoints to get their options... I don't know by how much it will effect the overall build. In general, this step is quite short compared to the actual build, so I doubt it will have a huge effect. |
vite-node
instance when importing entrypoints
@wxt-dev/auto-icons
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/storage
@wxt-dev/unocss
wxt
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 81.29% 81.03% -0.26%
==========================================
Files 128 128
Lines 6245 6286 +41
Branches 1066 1066
==========================================
+ Hits 5077 5094 +17
- Misses 1153 1177 +24
Partials 15 15 ☔ View full report in Codecov by Sentry. |
vite-node
instance when importing entrypoints
This PR refactors the logic around how options are imported from JS entrypoints. Each entrypoint is still read and imported in parallel, but now only one instance of the
vite-node
dev server is ever setup (instead of one for every JS/TS entrypoint). This closes #1204.Additionally, while doing the above refactor, I've reduced the footprint of the polyfilled extension environment while entrypoints are imported. Instead of creating multiple environments and polyfilling them in parallel, causing race conditions, the environment is polyfilled only once and is only present while importing the entrypoints. Before, the extension environment was also polyfilled when resolving vite config, the source of #931 (comment). This PR closes #931, and replaces #1231.