Remove read arguments not available in zsh #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsh uses -k 1 instead of -n 1, so these are easy to fix. With -e, we can get almost the same effect by just doing an echo afterward instead. For the nickname prompt, we don't even need -e or echo as the user is already entering a newline.
|
@daveFNbuck I recently moved over to zsh on my mac, and I get errors about compdef if I source hyperjump in my .zshrc. Any chance we can work together and merge your changes and my pull request #11 for the "jp/jump-push" into a unified tree, since @x0054 seems to not be interested? |
|
Sure, I can add my pull request if you make a fork. |
|
I have an existing fork here: https://github.com/alanhoyle/hyperjump I'm not sure about the protocol for how to handle these things though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zsh uses -k 1 instead of -n 1, so these are easy to fix. With -e, we can
get almost the same effect by just doing an echo afterward instead. For
the nickname prompt, we don't even need -e or echo as the user is
already entering a newline.