Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8.12.1, CI Improvements, 1.21.1 as base #559

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

Kichura
Copy link

@Kichura Kichura commented Dec 21, 2024

  1. Reworks the entire workflow system to be much more efficient at compiling time,
  2. Updates Gradle to 8.12 and makes the gradlew file executtable on UNIX-based systems, (Requires Loom to be on 1.9.x)
  3. Upgrades Minecraft build from 1.21 -> 1.21.1, This is to remain consistent with the Fabric API version that is set in gradle.properties file,
  4. Fixes broken build path in .gitignore.

Kichura and others added 4 commits December 21, 2024 01:40
In the event something goes wrong in terms of the OS, best to freeze it to 22.04 for now.
Not required for workflows that don't need this for action test runs before submitting.
Just came out, Gradle updates are tracked here: https://services.gradle.org/versions/current
@Kichura Kichura changed the title Gradle 8.11.1, CI Improvements, 1.21.1 as base Gradle 8.12, CI Improvements, 1.21.1 as base Dec 21, 2024
@Kichura Kichura changed the title Gradle 8.12, CI Improvements, 1.21.1 as base Gradle 8.12.1, CI Improvements, 1.21.1 as base Jan 25, 2025
@xCollateral
Copy link
Owner

I think it's best to let maintainers update gradle and dependencies version.
Workflow and .gitignore changes seem fine.

@Kichura
Copy link
Author

Kichura commented Feb 3, 2025

I think it's best to let maintainers update gradle and dependencies version. Workflow and .gitignore changes seem fine.

The gradlew is not chmod +x'd, this makes it slightly annoying to compile your mod atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants