IDebugLogs to Game/Logs folder #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lStewieAl
requested changes
Jul 10, 2021
Updated with file ID handle. |
|
If you could make this change optional through INI then that'd be great. I myself am not keen on having the file in a Logs folder since I frequently look at logs and it's handy for me to have the base game folder open at all times and I can just use my keyboard to find it quickly to open it. |
Moved a lot to cppLatest Also fixed some offbyone errors in enum type checks where enum MAX was included, meaning arrays were accessed out-of-bounds.
Moved lots to CppLatest. Fixed a few off-by-one bugs in enum evaluation (MAX was included where array sizes were MAX-1) Some other misc changes.
|
So this thing has been open for two years. Do you think it is time to close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to IDebugLogs to update it and move the logs created by xNVSE to be located in Logs folder in Game folder (C:\Steam\SteamApps\Common\Fallout New Vegas) for easier access over installed plugins, if such a feature is desired.
Tested with debug/release compile and with MO2 modded setup.