This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Bugfix/fix tests on i386 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @avalentino , sorry I missed this when you submitted it. I have absolutely no idea why your change is really doing here, and I suspect it must be related to a bug upstream in either xarray or numpy. I would appreciate it if you could explain a little more about the behaviour you found here? |
|
On i386 integers are interpreted as |
TomNicholas
reviewed
Oct 24, 2023
|
Oh right! Thank you @avalentino - merging this now. |
|
Thanks @TomNicholas |
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* Fix tests on i386 * Update changelog * Add comment explaining explicit cast --------- Co-authored-by: Tom Nicholas <[email protected]> Co-authored-by: Tom Nicholas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-filesdocs/source/whats-new.rst