This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
FIX: Fix bug with nodepath python 3.12 issues #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomNicholas - this should be ready for review. I added tests here along with the fix, and updated the CI workflow. |
TomNicholas
approved these changes
Oct 17, 2023
Co-authored-by: Tom Nicholas <[email protected]>
for more information, see https://pre-commit.ci
…/datatree into fix-nodepath-python-312
Absolutely! Thanks for all the suggestions - I incorporated those, and it should be good to go after the CI passes. |
Closed
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
…#260 * ADD: Add test support for python 3.12 * ADD: Add to whats new doc * Apply suggestions from review Co-authored-by: Tom Nicholas <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * FIX: Add 3.12 to dev build --------- Co-authored-by: Tom Nicholas <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a subclassing issue with the NodePath class currently implemented in datatree. This also adds a test for the NodePath class, and adds tests for python 3.12. A check for python version is used to ensure backwards compatibility.
pre-commit run --all-filesapi.rstdocs/source/whats-new.rst