Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.cbcolympics] 2.3.1+krypton.1 #4544

Closed
wants to merge 1 commit into from

Conversation

fourpointsix
Copy link

Description

Updated for Paris 2024

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

@fourpointsix
Copy link
Author

fourpointsix commented Jul 27, 2024

The checker errors with "Add-ons should target Python 3 and up." but if I recall correctly, Krypton only has Python 2. Is this just a failure of the checker to limit that rule to Matrix and up?

@fourpointsix fourpointsix force-pushed the paris2024-krypton branch 2 times, most recently from fa4de4a to 3156b2e Compare July 27, 2024 10:47
@fourpointsix fourpointsix changed the title [plugin.video.cbcolympics] 2.3.0+krypton.1 [plugin.video.cbcolympics] 2.3.1+krypton.1 Jul 28, 2024
@eracknaphobia
Copy link

Sorry, we are no longer accepting PR's for add-ons that require Python 2. Only Python 3 add-ons are accepted. So basically Kodi Matrix and up.

@fourpointsix
Copy link
Author

Sorry, we are no longer accepting PR's for add-ons that require Python 2. Only Python 3 add-ons are accepted. So basically Kodi Matrix and up.

OK, no worries, thanks for the update. I'll get a Wiki account and modify it to reflect that, as it currently says that updates are still being accepted for Gotham and up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants