Implemented suggested changes

xdslproject · Jan 30, 2025 · ae2ac64 · ae2ac64
1 parent d24f9fd
commit ae2ac64
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/tests/dialects/test_builtin.py b/tests/dialects/test_builtin.py
@@ -10,6 +10,7 @@
     AnyVectorType,
     ArrayAttr,
     BFloat16Type,
+    BoolAttr,
     BytesAttr,
     ComplexType,
     DenseArrayBase,
@@ -188,9 +189,9 @@ def test_IntAttr___bool__():
     assert IntAttr(1)
 
 
-def test_IntegerAttr___bool__():
-    assert not IntegerAttr.from_bool(False)
-    assert IntegerAttr.from_bool(True)
+def test_BoolAttr___bool__():
+    assert not BoolAttr.from_bool(False)
+    assert BoolAttr.from_bool(True)
 
 
 def test_IntegerType_packing():

diff --git a/xdsl/parser/base_parser.py b/xdsl/parser/base_parser.py
@@ -45,7 +45,7 @@ def parse_optional_integer(
         """
         Parse an (possible negative) integer. The integer can either be
         decimal or hexadecimal.
-        Optionally allow parsing of 'true' or 'false' into -1 and 0.
+        Optionally allow parsing of 'true' or 'false' into 1 and 0.
         """
         # Parse true and false if needed
         if allow_boolean:
@@ -78,7 +78,7 @@ def parse_integer(
         """
         Parse an (possible negative) integer. The integer can
         either be decimal or hexadecimal.
-        Optionally allow parsing of 'true' or 'false' into -1 and 0.
+        Optionally allow parsing of 'true' or 'false' into 1 and 0.
         """
 
         return self.expect(
@@ -121,7 +121,7 @@ def parse_optional_number(
     ) -> int | float | None:
         """
         Parse a (possibly negative) integer or float literal, if present.
-        Can optionally parse 'true' or 'false' into -1 and 0.
+        Can optionally parse 'true' or 'false' into 1 and 0.
         """
 
         is_negative = self._parse_optional_token(MLIRTokenKind.MINUS) is not None
@@ -149,7 +149,7 @@ def parse_number(
     ) -> int | float:
         """
         Parse a (possibly negative) integer or float literal.
-        Can optionally parse 'true' or 'false' into -1 and 0.
+        Can optionally parse 'true' or 'false' into 1 and 0.
         """
         return self.expect(
             lambda: self.parse_optional_number(allow_boolean=allow_boolean),