core: (assembly-format) omit default attributes/properties from attr-dict directive #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
bug
alexarice
requested review from
superlopuh,
AntonLydike,
math-fehr and
PapyChacal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3783 +/- ##
==========================================
- Coverage 91.25% 91.25% -0.01%
==========================================
Files 461 461
Lines 57490 57519 +29
Branches 5543 5543
==========================================
+ Hits 52465 52491 +26
- Misses 3603 3604 +1
- Partials 1422 1424 +2 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Jan 23, 2025
| not (set(op.attributes.keys()) | set(op.properties.keys())) | ||
| - self.reserved_attr_names | ||
| ): | ||
| return | ||
| if any(name in op.attributes for name in op.properties): | ||
| raise ValueError( | ||
| "Cannot print attributes and properties with the same name " | ||
| "in a signle dictionary" |
There was a problem hiding this comment.
Can you fix this typo while you're at it? 🙃
Suggested change
| "in a signle dictionary" | |
| "in a single dictionary" |
superlopuh
reviewed
Jan 23, 2025
Comment on lines
464
to
471
| default_names = set( | ||
| name | ||
| for name, d in op_def.attributes.items() | ||
| if d.default_value is not None | ||
| and op.attributes.get(name) == d.default_value | ||
| ) | ||
| reserved_or_default = self.reserved_attr_names | default_names | ||
| if not set(op.attributes.keys()) - reserved_or_default: |
There was a problem hiding this comment.
nit:
Suggested change
| default_names = set( | |
| name | |
| for name, d in op_def.attributes.items() | |
| if d.default_value is not None | |
| and op.attributes.get(name) == d.default_value | |
| ) | |
| reserved_or_default = self.reserved_attr_names | default_names | |
| if not set(op.attributes.keys()) - reserved_or_default: | |
| reserved_or_default = self.reserved_attr_names.update( | |
| name | |
| for name, d in op_def.attributes.items() | |
| if d.default_value is not None | |
| and op.attributes.get(name) == d.default_value | |
| ) | |
| if not reserved_or_default.is_superset(op.attributes.keys()): |
Two proposals, each of which avoids a set construction, seems a tiny bit cleaner
There was a problem hiding this comment.
update is a mutating function right? (I can't mutate self.reserved_attr_names)
superlopuh
approved these changes
Jan 24, 2025
compor
approved these changes
Jan 24, 2025
|
Should I still refactor to use |
|
It's a bit of a nit, and it's unlikely to be a perf bottleneck, but it seems like a good opportunity to do so, sets aren't free :) |
|
Great, will wait for CI then merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
attr-dictdirective currently prints attributes/properties which are set to the default value, which is not the correct behaviour.