core: (constraints) add IntAttrConstraint #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
requested review from
superlopuh,
compor,
math-fehr,
PapyChacal and
kimxworrall
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3797 +/- ##
==========================================
+ Coverage 91.23% 91.25% +0.01%
==========================================
Files 461 461
Lines 57480 57557 +77
Branches 5547 5549 +2
==========================================
+ Hits 52443 52523 +80
+ Misses 3615 3609 -6
- Partials 1422 1425 +3 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Jan 29, 2025
| ) | ||
| def test_int_attr_extraction(program: str): | ||
| @irdl_op_definition | ||
| class IntAttrExtractOp(IRDLOperation): |
There was a problem hiding this comment.
Mind pulling this and one below out and use a single definition? Fewer lines of code to eyeball over.
Comment on lines
3237
to
3238
| class IntAttrExtractOp(IRDLOperation): | ||
| name = "test.int_attr_verify" |
There was a problem hiding this comment.
Same here, plus a name for the class and its name that match (here one uses 'extract' and the other uses 'verify'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a constraint that applies an integer constraint to the value of an integer attribute.
See: https://github.com/xdslproject/inconspiquous/blob/70f923cfe577b7eb48ece03d6f9a597c296cb698/inconspiquous/dialects/gate.py#L237
and https://github.com/xdslproject/inconspiquous/blob/70f923cfe577b7eb48ece03d6f9a597c296cb698/inconspiquous/dialects/qssa.py#L78
for an example of using this.
I'm unsure if this is the best place for this to live, or if it should be upstreamed at all.