-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: (convert-memref-to-ptr) add lower-func flag #3820
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3820 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 461 461
Lines 57560 57635 +75
Branches 5549 5567 +18
=======================================
+ Hits 52526 52596 +70
- Misses 3609 3612 +3
- Partials 1425 1427 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo comments!
Cc @mamanain |
Our PR convention is to let the commenter resolve the comment, which makes it easier to track conversations. LMK if you'd like help with the tests. |
Adds a
lower-func
boolean flag toconvert-memref-to-ptr
that rewrites function definitions and calls containingmemref
to useptr
.This applies 4 additional rewrite patterns after the existing rewrites:
LowerMemrefFuncOpPattern
LowerMemrefFuncCallPattern
LowerMemrefFuncReturnPattern
ReconcileUnrealizedPtrCasts