Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (convert-memref-to-ptr) add lower-func flag #3820

Merged
merged 12 commits into from
Feb 2, 2025

Conversation

kaylendog
Copy link
Contributor

Adds a lower-func boolean flag to convert-memref-to-ptr that rewrites function definitions and calls containing memref to use ptr.

This applies 4 additional rewrite patterns after the existing rewrites:

  1. LowerMemrefFuncOpPattern
  2. LowerMemrefFuncCallPattern
  3. LowerMemrefFuncReturnPattern
  4. ReconcileUnrealizedPtrCasts

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (3a9e8b3) to head (aed42b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3820   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         461      461           
  Lines       57560    57635   +75     
  Branches     5549     5567   +18     
=======================================
+ Hits        52526    52596   +70     
- Misses       3609     3612    +3     
- Partials     1425     1427    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments!

xdsl/transforms/convert_memref_to_ptr.py Outdated Show resolved Hide resolved
xdsl/transforms/convert_memref_to_ptr.py Outdated Show resolved Hide resolved
xdsl/transforms/convert_memref_to_ptr.py Outdated Show resolved Hide resolved
xdsl/transforms/convert_memref_to_ptr.py Outdated Show resolved Hide resolved
@superlopuh
Copy link
Member

Cc @mamanain

@superlopuh
Copy link
Member

Our PR convention is to let the commenter resolve the comment, which makes it easier to track conversations.

LMK if you'd like help with the tests.

@superlopuh superlopuh added the transformations Changes or adds a transformatio label Feb 2, 2025
@superlopuh superlopuh merged commit dce19da into xdslproject:main Feb 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants