-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: make all constr methods classmethods #3826
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3826 +/- ##
=======================================
Coverage 91.25% 91.25%
=======================================
Files 461 461
Lines 57627 57627
Branches 5567 5567
=======================================
Hits 52588 52588
Misses 3612 3612
Partials 1427 1427 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In similar vein as in #3821 I assume?
Yes |
Would it make sense to migrate |
My plan was to start chipping away at these after #3828 |
kk |
Makes every constr method (found with ripgrep
def\ constr
) a classmethod instead of a staticmethod. This is in preparation for adding a defaultconstr
method toAttribute
in a future PR.