Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make all constr methods classmethods #3826

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

alexarice
Copy link
Collaborator

Makes every constr method (found with ripgrep def\ constr) a classmethod instead of a staticmethod. This is in preparation for adding a default constr method to Attribute in a future PR.

@alexarice alexarice added minor For minor PRs, easy and quick to review, quickly mergeable core xDSL core (ir, textual format, ...) labels Feb 4, 2025
@alexarice alexarice self-assigned this Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (a345d2a) to head (c3d7a49).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3826   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         461      461           
  Lines       57627    57627           
  Branches     5567     5567           
=======================================
  Hits        52588    52588           
  Misses       3612     3612           
  Partials     1427     1427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@compor compor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In similar vein as in #3821 I assume?

@alexarice
Copy link
Collaborator Author

Yes

@superlopuh
Copy link
Member

Would it make sense to migrate AnyMemRefTypeConstr and AnyIntegerTypeConstr with this PR? Ideally to MemRefType.constr() and IntegerType.constr()

@alexarice
Copy link
Collaborator Author

My plan was to start chipping away at these after #3828

@superlopuh
Copy link
Member

kk

@alexarice alexarice merged commit df20509 into main Feb 4, 2025
16 checks passed
@alexarice alexarice deleted the alexarice/constr-classmethod branch February 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants