core: Add shorthand type for types that can be converted to IRDL #3836
+91
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math-fehr
added a commit
that referenced
this pull request
Feb 5, 2025
stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
d3123ea to
e30ef17
Compare
math-fehr
force-pushed
the
math-fehr/stack/1
branch
from
a0bed84 to
2c7e966
Compare
math-fehr
added a commit
that referenced
this pull request
Feb 5, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
e30ef17 to
5bc7c8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3836 +/- ##
==========================================
- Coverage 91.26% 91.26% -0.01%
==========================================
Files 465 465
Lines 57911 57920 +9
Branches 5578 5579 +1
==========================================
+ Hits 52851 52858 +7
- Misses 3634 3635 +1
- Partials 1426 1427 +1 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Feb 5, 2025
| @@ -93,7 +93,9 @@ def isa(arg: Any, hint: "TypeForm[_T]") -> TypeGuard[_T]: | |||
| from xdsl.irdl import GenericData, irdl_to_attr_constraint | |||
|
|
|||
| if (origin is not None) and issubclass(origin, GenericData | ParametrizedAttribute): | |||
| constraint = irdl_to_attr_constraint(hint) | |||
| constraint = irdl_to_attr_constraint( | |||
| hint # pyright: ignore[reportArgumentType] | |||
There was a problem hiding this comment.
pyright cannot understand that hint is either a GenericData or a ParametrizedAttribute. That's because the typing we deduce for origin doesn't spread to hint.
math-fehr
added a commit
that referenced
this pull request
Feb 5, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
added a commit
that referenced
this pull request
Feb 5, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
5bc7c8d to
d30b321
Compare
alexarice
approved these changes
Feb 5, 2025
math-fehr
added a commit
that referenced
this pull request
Feb 6, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
d30b321 to
763d108
Compare
math-fehr
added a commit
that referenced
this pull request
Feb 6, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
added a commit
that referenced
this pull request
Feb 6, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
763d108 to
c6cc4a9
Compare
This includes default to AttributeInvT and AttributeCovT. stack-info: PR: #3835, branch: math-fehr/stack/1
math-fehr
added a commit
that referenced
this pull request
Feb 6, 2025
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
c6cc4a9 to
5bcfd9e
Compare
Closed
There was a lot of inconsistencies in the typing of functions that are using the type to constraint conversion. Having a shorthand makes this more explicit. stack-info: PR: #3836, branch: math-fehr/stack/2
math-fehr
force-pushed
the
math-fehr/stack/2
branch
from
5bcfd9e to
55d2296
Compare
superlopuh
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
core: Add shorthand type for types that can be converted to IRDL
There was a lot of inconsistencies in the typing of functions that are
using the type to constraint conversion. Having a shorthand makes this
more explicit.