dialects: (linalg) add hidden region to transpose op #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorendumoulin
commented
Feb 5, 2025
There was a problem hiding this comment.
this filecheck had invalid generic format, so i converted it to use the custom format
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3838 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 461 461
Lines 57643 57648 +5
Branches 5571 5571
=======================================
+ Hits 52605 52610 +5
Misses 3613 3613
Partials 1425 1425 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Feb 5, 2025
compor
approved these changes
Feb 5, 2025
7 tasks
jorendumoulin
added a commit
that referenced
this pull request
Feb 5, 2025
…ck (#3837) This PR adds generic printing to the mlir conversion filecheck This will check whether the issues posed in #2959 are correctly resolved, by checking if mlir correctly parses the generic output of xdsl There are still reminaing issues, solved in the following PRs: (stacked on: ) #3838, #3839, #3840, #3841
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
This adds a hidden region to the linalg.transpose op to ensure correct generic printing Also changes permutation to a property instead of attribute. This resolves the transpose op in #2959 This has now been checked manually, and will be put in ci with #3837 (but for that 3 other ops need to be fixed, PRs incoming...)
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
…ck (#3837) This PR adds generic printing to the mlir conversion filecheck This will check whether the issues posed in #2959 are correctly resolved, by checking if mlir correctly parses the generic output of xdsl There are still reminaing issues, solved in the following PRs: (stacked on: ) #3838, #3839, #3840, #3841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a hidden region to the linalg.transpose op to ensure correct generic printing
Also changes permutation to a property instead of attribute.
This resolves the transpose op in #2959
This has now been checked manually, and will be put in ci with #3837 (but for that 3 other ops need to be fixed, PRs incoming...)