dialects: (builtin) remove AnyFloatAttr(Constr)? #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a merge disaster, I'll just redo it |
alexarice
force-pushed
the
alexarice/float-defaults
branch
from
235755a to
49c65fe
Compare
alexarice
force-pushed
the
alexarice/float-defaults
branch
from
49c65fe to
a517805
Compare
|
Should be fixed now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3844 +/- ##
=======================================
Coverage 91.26% 91.27%
=======================================
Files 461 461
Lines 57656 57654 -2
Branches 5570 5570
=======================================
+ Hits 52619 52621 +2
+ Misses 3612 3609 -3
+ Partials 1425 1424 -1 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Feb 5, 2025
emmau678
pushed a commit
that referenced
this pull request
Feb 6, 2025
Adds a default type to `FloatAttr` and removes `AnyFloatAttr` and `AnyFloatAttrConstr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default type to
FloatAttrand removesAnyFloatAttrandAnyFloatAttrConstr