Single overcast command should be a list of overthere arguments. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilx
changed the title
|
XebiaLabs » overcast #106 SUCCESS |
| @@ -89,6 +89,10 @@ public static String getOvercastProperty(String key) { | |||
| return getOvercastProperty(key, null); | |||
| } | |||
|
|
|||
| public static List<String> getOvercastProperties(String key) { | |||
| return getOvercastProperties(key, (String)null); | |||
There was a problem hiding this comment.
Hmm do I see correctly that if the key is not there a non empty list with a null value is returned? Would it make more sense to return an empty list or a null (ugly but more consistent with how the other ones work)?
There was a problem hiding this comment.
I did it on purpose because I wanted to see NPE :)
I'm gonna change it to empty list.
|
XebiaLabs » overcast #109 SUCCESS |
|
@rklaren any chance to merge this? |
|
@ilx thanks for pinging, I had forgotten about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.