Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PickController cache pick results #1264

Closed
wants to merge 1 commit into from
Closed

PickController cache pick results #1264

wants to merge 1 commit into from

Conversation

xeolabs
Copy link
Member

@xeolabs xeolabs commented Nov 25, 2023 •
edited
Loading

Just a PR for demonstration purposes. Shows how we could cache pick results on pickController.

This could be improved:

  • Cache and return results against the hash
  • Blow away cached results, along with the hash, on each Scene "rendered"

@ghost
Copy link

ghost commented Nov 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@xeolabs xeolabs mentioned this pull request Nov 25, 2023
Closed
@xeolabs xeolabs closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xeolabs