-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement section caps through sceneModelEntity:capMaterial #1775
base: master
Are you sure you want to change the base?
Conversation
Ok, I will give it a try :) |
examples/slicing/SectionPlanesPlugin_Duplex_SectionCaps.html
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys, I'm testing it on various different models, it works better than I thought. It runs quite fast and gets quite good results. But also it has some limitations:
- models have to have all meshes closed (solids). But in reality many models have none of them closed or only some of them closed, which results in only partial caps / no caps.
- for huge models (such as WestRiverSideHospital) it crashes my browser.
- it doesn't work once I set the position of the model (it doesn't cap then)
- I think it would be good to check the model far from origin, but I can't remember which one was it. Do you remember @xeolabs?
Because of the above I'm thinking if maybe it would be better to add this functionality more as an example rather than a xeokit-sdk functionality? What do you guys think?
Hi @paireks! Thank you for trying out this feature and your valuable feedback.
|
I've added a section plane and capMaterials to the |
d324265
to
01c0856
Compare
01c0856
to
a722993
Compare
Please give this branch a test and let me know if you see any bugs so that we can fix it before merging into main.