Add some comments

xh · Jan 28, 2025 · 776036d · 776036d
1 parent b54e21f
commit 776036d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/grails-app/init/io/xh/hoist/ClusterConfig.groovy b/grails-app/init/io/xh/hoist/ClusterConfig.groovy
@@ -132,8 +132,12 @@ class ClusterConfig {
      * Hoist Core's `ClientErrorService` for an example.
      */
     protected void createDefaultConfigs(Config config) {
-        config.setProperty('hazelcast.shutdownhook.enabled', 'false')
+
         config.setProperty('hazelcast.logging.type', 'slf4j')
+
+        // Hoist core will orchestrate hz shutdown from its own hook: See HoistCoreGrailsPlugin
+        config.setProperty('hazelcast.shutdownhook.enabled', 'false')
+
         config.getMapConfig('default').with {
             statisticsEnabled = true
             inMemoryFormat = InMemoryFormat.OBJECT

diff --git a/grails-app/services/io/xh/hoist/cluster/ClusterService.groovy b/grails-app/services/io/xh/hoist/cluster/ClusterService.groovy
@@ -152,7 +152,7 @@ class ClusterService extends BaseService implements ApplicationListener<Applicat
      * Shutdown this instance.
      */
     void shutdownInstance() {
-        logInfo("Initiating shutdown via System.exit.")
+        logInfo('Initiating shutdown via System.exit.')
         System.exit(0)
     }
 

diff --git a/src/main/groovy/io/xh/hoist/HoistCoreGrailsPlugin.groovy b/src/main/groovy/io/xh/hoist/HoistCoreGrailsPlugin.groovy
@@ -65,6 +65,7 @@ class HoistCoreGrailsPlugin extends Plugin {
     void onConfigChange(Map<String, Object> event) {}
 
     void onShutdown(Map<String, Object> event) {
+        // Orchestrate shutdown here. This is *after* all plugin and app Bootstrap.destroy() have run
         Timer.shutdownAll()
         ClusterService.shutdownHazelcast()
     }