Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Tweaks to make better UX #366

Merged
merged 4 commits into from
Dec 29, 2023
Merged

UI Tweaks to make better UX #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84f8a8e
www/App: Disable AWS buttons in the frontend
vibhoothi Dec 17, 2023
525cdbc
www/Report: Only display analyzer links for AV1
vibhoothi Dec 17, 2023
58be1ac
www/SubmitJobForm: Omit Arch options in the UI
vibhoothi Dec 17, 2023
9e099e5
www/Job: Do not display A/B compare status and show task as set
vibhoothi Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions www/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ export class App extends React.Component<{}, void> {
<DebugComponent />
</div>
</Tab>,
<Tab eventKey={9} key="status" title="AWS Status">
<div style={{ padding: 10, height: height - 100, overflow: "scroll" }}>
<AppStatusComponent />
</div>
</Tab>,
// <Tab eventKey={9} key="status" title="AWS Status">
// <div style={{ padding: 10, height: height - 100, overflow: "scroll" }}>
// <AppStatusComponent />
// </div>
// </Tab>,
<Tab eventKey={10} key="login" title="Login">
<div style={{ padding: 10 }}>
<LoginComponent/>
Expand Down
6 changes: 3 additions & 3 deletions www/src/components/Job.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,10 @@ export class JobComponent extends React.Component<JobProps, {
if (job.buildOptions) details.push(keyValue("Build", job.buildOptions));
details.push(keyValue("Codec", job.codec));
details.push(keyValue("Commit", job.commit));
details.push(keyValue("Task", job.task));
details.push(keyValue("Set", job.task));
details.push(keyValue("Qualities", job.qualities));
details.push(keyValue("Run A/B Compare", job.runABCompare));
details.push(keyValue("Save Encoded Files", job.saveEncodedFiles));
// details.push(keyValue("Run A/B Compare", job.runABCompare));
// details.push(keyValue("Save Encoded Files", job.saveEncodedFiles));
if (job.ctcSets) details.push(keyValue("CTC Sets", JSON.stringify(job.ctcSets)));
if (job.ctcPresets) details.push(keyValue("CTC Presets", JSON.stringify(job.ctcPresets)));
if (job.ctcVersion) details.push(keyValue("CTC Version", job.ctcVersion));
Expand Down
14 changes: 14 additions & 0 deletions www/src/components/Report.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,20 @@ export class AnalyzerLinksComponent extends React.Component<{
let report = this.props.jobs[0].report;
let videoRows = [];
let videos = [];
// As the Web analyzer is only made for AV1, check the codec and then
// display the analyzer links, so users do not get confused
let analyzer_codecs = ['rav1e', 'svt-av1', 'av1'];

function isCodecMatch(job: Job): boolean {
return analyzer_codecs.some(codec => job.codec.includes(codec));
}

let areAllMatches = jobs.every(isCodecMatch);
if (areAllMatches == false) {
return <Panel header="Analyzer Links">
<p>Currently AWCY supports only AV1 for web analyzer</p>
</Panel>
}

for (let video in report) {
if (video != "Total") {
Expand Down
3 changes: 2 additions & 1 deletion www/src/components/SubmitJobForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,12 @@ export class SubmitJobFormComponent extends React.Component<{
<FormControl type="text" placeholder="30 40 50 ..."
value={job.qualities} onChange={this.onInputChange.bind(this, "qualities")} />
</FormGroup>

{/*
<FormGroup validationState={this.getValidationState("arch")}>
<ControlLabel>Architecture</ControlLabel>
<Select clearable={false} placeholder="Encoder" value={this.state.arch} options={archOptions} onChange={this.onChangeArch.bind(this)} />
</FormGroup>
*/}

<FormGroup validationState={this.getValidationState("ctcSets")}>
<ControlLabel>This will override the above set (for AOM-CTC)</ControlLabel>
Expand Down