Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python typing capability to the library. #15

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

AbstractUmbra
Copy link

Hello!

Thank you for creating this library, it is great and easy to use.

I have created this PR which achieves the following, in no particular order:-

  • Adds license header to relevant files.
  • Clean up around the code base, like __all__ specification and class __slots__.
  • Renames some constants to align with standard Python practices.
  • Add complete types to the code.
  • Add a GitHub workflow that runs on PR or on commit to master to check the types and functionality of the codebase from Python 3.7 -> 3.11.

I didn't want to edit functionality of the codebase for now, but in a future PR I may add a more object-style usage to the return types of the client methods, or at the very least ensure the payload types are known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant