adds find_or_create_dm_by_inbox_id #1564
Merged
+219
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
commented
Jan 29, 2025
| @@ -272,10 +272,10 @@ impl Conversations { | |||
| } | |||
|
|
|||
| #[wasm_bindgen(js_name = createDm)] | |||
| pub async fn create_dm(&self, account_address: String) -> Result<Conversation, JsError> { | |||
| pub async fn find_or_create_dm(&self, account_address: String) -> Result<Conversation, JsError> { | |||
There was a problem hiding this comment.
@rygine I thought updating the name in bindings for clarity would be helpful. let me know if there's any concerns
cameronvoell
commented
Jan 29, 2025
|
|
||
| /// Create a new Direct Message with the default settings | ||
| pub async fn create_dm_by_inbox_id( | ||
| async fn create_dm_by_inbox_id( |
There was a problem hiding this comment.
removing public visibility, since we never really want to be creating a dm when another exists already
rygine
previously approved these changes
Jan 29, 2025
cameronvoell
force-pushed
the
cv/01-28-adds_find_or_create_dm_by_inbox_id
branch
from
e1a54bd to
4c1a90a
Compare
insipx
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds find_or_create_dm_by_inbox_id
update bindings to use find_or_create_dm_by_inbox_id