Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant clippy checks from CI #1573

Merged
merged 1 commit into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions .github/workflows/lint-ffi-bindings.yaml

This file was deleted.

24 changes: 0 additions & 24 deletions .github/workflows/lint-node-bindings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,37 +5,13 @@ on:
- "bindings_node/**"
- ".github/workflows/lint-node-bindings.yaml"
- "rustfmt.toml"
env:
CARGO_TERM_COLOR: always
CARGO_INCREMENTAL: 0
RUSTFLAGS: -D warnings --cfg tracing_unstable
CARGO_PROFILE_TEST_DEBUG: 0
jobs:
lint:
name: Lint
runs-on: warp-ubuntu-latest-x64-16x
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Update rust toolchains
run: rustup update
- uses: taiki-e/install-action@v2
with:
tool: clippy-sarif,sarif-fmt
- name: Cache
uses: Swatinem/rust-cache@v2
with:
workspaces: |
.
bindings_node
- name: Run clippy and fail on warnings
run: cargo clippy --locked --manifest-path bindings_node/Cargo.toml --all-features --all-targets --no-deps --message-format=json | clippy-sarif | tee results.sarif | sarif-fmt
- name: Upload SARIF file
uses: github/codeql-action/upload-sarif@v2
with:
sarif_file: results.sarif
- name: Run format check
run: cargo fmt --manifest-path bindings_node/Cargo.toml --check
- name: Setup node
uses: actions/setup-node@v4
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ on:
- "xmtp_proto/**"
- "xmtp_v2/**"
- "xmtp_debug/**"
- "bindings_node/**"
- "bindings_ffi/**"
- "Cargo.toml"
- "Cargo.lock"
- "rust-toolchain"
Expand Down
Loading