Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare node bindings for release #1578

Merged
merged 2 commits into from
Feb 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bindings_node/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# @xmtp/node-bindings

## 0.0.36

- Fixed DM group metadata validation

## 0.0.35

- Updated `createDm` to return an existing DM group, if it exists
Expand Down
2 changes: 1 addition & 1 deletion bindings_node/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@xmtp/node-bindings",
"version": "0.0.35",
"version": "0.0.36",
"repository": {
"type": "git",
"url": "git+https://[email protected]/xmtp/libxmtp.git",
Expand Down
32 changes: 31 additions & 1 deletion bindings_node/test/Conversations.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -488,11 +488,32 @@ describe('Conversations', () => {
await client1.conversations().createGroup([user3.account.address])
await client1.conversations().createDm(user4.account.address)

let messages: Message[] = []
const messages: Message[] = []
const stream = client1.conversations().streamAllMessages((err, message) => {
messages.push(message!)
})

const messages2: Message[] = []
const stream2 = client2
.conversations()
.streamAllMessages((err, message) => {
messages2.push(message!)
})

const messages3: Message[] = []
const stream3 = client3
.conversations()
.streamAllMessages((err, message) => {
messages3.push(message!)
})

const messages4: Message[] = []
const stream4 = client4
.conversations()
.streamAllMessages((err, message) => {
messages4.push(message!)
})

const groups2 = client2.conversations()
await groups2.sync()
const groupsList2 = groups2.list()
Expand All @@ -512,8 +533,17 @@ describe('Conversations', () => {
await sleep()

stream.end()
stream2.end()
stream3.end()
stream4.end()
expect(messages.length).toBe(3)
expect(messages.map((m) => m.id)).toEqual([message1, message2, message3])
expect(messages2.length).toBe(1)
expect(messages2.map((m) => m.id)).toEqual([message1])
expect(messages3.length).toBe(1)
expect(messages3.map((m) => m.id)).toEqual([message2])
expect(messages4.length).toBe(1)
expect(messages4.map((m) => m.id)).toEqual([message3])
})

it('should only stream group chat messages', async () => {
Expand Down
1 change: 1 addition & 0 deletions bindings_node/vitest.config.mts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const viteConfig = defineConfig({
const vitestConfig = defineVitestConfig({
test: {
globalSetup: ['./vitest.setup.mts'],
testTimeout: 30000,
},
})

Expand Down
Loading