Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi remote attachment content type #1609

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Feb 7, 2025

@cameronvoell cameronvoell force-pushed the cv/multi-attachment-content-type branch from 37302b9 to 3efadc3 Compare February 7, 2025 20:46
@cameronvoell cameronvoell changed the title update protos and add new multi remote attachment content type multi remote attachment content type Feb 11, 2025
@cameronvoell cameronvoell marked this pull request as ready for review February 13, 2025 14:56
@cameronvoell cameronvoell requested a review from a team as a code owner February 13, 2025 14:56
@cameronvoell cameronvoell changed the title multi remote attachment content type Multi remote attachment content type Feb 13, 2025
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we need to write these codecs in Kotlin and Swift now too? Or do they live entirely in Rust? Assuming we will still need to for registering the codecs on the client?

@cameronvoell
Copy link
Contributor Author

Will we need to write these codecs in Kotlin and Swift now too? Or do they live entirely in Rust? Assuming we will still need to for registering the codecs on the client?

@nplasterer We still need to have Codec classes in Kotlin + Swift, but we can borrow the encode/decode logic from rust which sort of enforces a contract on how the data is represented, which roots back to the proto repo. So this is moderately better than the JSON types which you had to write more "manual" parsing for.

@cameronvoell cameronvoell merged commit c57c5fa into main Feb 13, 2025
18 checks passed
@cameronvoell cameronvoell deleted the cv/multi-attachment-content-type branch February 13, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants