-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi remote attachment content type #1609
Conversation
37302b9
to
3efadc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need to write these codecs in Kotlin and Swift now too? Or do they live entirely in Rust? Assuming we will still need to for registering the codecs on the client?
@nplasterer We still need to have Codec classes in Kotlin + Swift, but we can borrow the encode/decode logic from rust which sort of enforces a contract on how the data is represented, which roots back to the proto repo. So this is moderately better than the JSON types which you had to write more "manual" parsing for. |
Related to https://github.com/xmtp/XIPs/blob/main/XIPs/xip-50-multiple-remote-attachments-content-type.md
Todo: