Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(disappearing-messages): store settings from welcome message #1619

Merged
merged 12 commits into from
Feb 10, 2025

Conversation

mchenani
Copy link
Contributor

  • Storing disappearing settings from the welcome message.
  • Exposing disappearing settings when creating DMs.
  • Fetch disappearing settings directly from the DB when getting them in other places

expose disappearing setting for creating dms
returning disappearing settings from the db
@mchenani mchenani requested a review from a team as a code owner February 10, 2025 14:15
@@ -539,12 +548,16 @@ impl<ScopedClient: ScopedGroupClient> MlsGroup<ScopedClient> {
client: Arc<ScopedClient>,
membership_state: GroupMembershipState,
dm_target_inbox_id: InboxId,
opts: DMMetadataOptions,
Copy link
Contributor

@codabrink codabrink Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, definitely felt like this was missing 😄

@mchenani mchenani merged commit f5b1089 into main Feb 10, 2025
14 checks passed
@mchenani mchenani deleted the mc/insert-disappearing-msgs-settings-from-welcome branch February 10, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants