Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API prototype #1628

Merged
merged 4 commits into from
Feb 18, 2025
Merged

API prototype #1628

merged 4 commits into from
Feb 18, 2025

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 13, 2025 •
edited
Loading

d14n API in xmtp_api_d14n

  • add xmtp_api_d14n
  • add d14n methods, get_inbox_ids, query_envelopes, publish_client_envelopes

@insipx insipx requested a review from a team as a code owner February 13, 2025 22:30
@insipx insipx marked this pull request as draft February 13, 2025 22:30
@insipx insipx marked this pull request as ready for review February 18, 2025 15:56
@insipx insipx requested a review from a team as a code owner February 18, 2025 15:56
mchenani
mchenani reviewed Feb 18, 2025
View reviewed changes
xmtp_api_d14n/Cargo.toml Outdated Show resolved Hide resolved
@insipx insipx force-pushed the insipx/prototype-api branch 2 times, most recently from e11f2cd to 9c011d5 Compare February 18, 2025 16:01
@insipx
Prototype a new api strategy
5bfb259 
- increase code sharing between grpc and http
- set up our codebase for simplifying traits in xmtp_mls
- make it easier to add/remove/modify api
- make api more rust idiomatic
@insipx insipx force-pushed the insipx/prototype-api branch from 9c011d5 to 5bfb259 Compare February 18, 2025 16:02
@insipx insipx mentioned this pull request Feb 18, 2025
Open
13 tasks
@insipx insipx requested a review from mchenani February 18, 2025 17:03
mchenani
mchenani approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG🔥🤘🚀

@insipx insipx enabled auto-merge (squash) February 18, 2025 17:32
@insipx insipx merged commit c40bda5 into main Feb 18, 2025
15 checks passed
@insipx insipx deleted the insipx/prototype-api branch February 18, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchenani mchenani mchenani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insipx @mchenani