Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Stream Test + Fixes #1646

Merged
merged 12 commits into from
Feb 20, 2025
Merged

Message Stream Test + Fixes #1646

merged 12 commits into from
Feb 20, 2025
+338 −179

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 18, 2025 •
edited
Loading

  • logging improvements
    • allow replacing inbox id with a name (alix, bo, eve, etc) in test logs
let mut replace = xmtp_common::InboxIdReplace::new();
replace.add(caro.inbox_id(), "caro");
replace.add(eve.inbox_id(), "eve");
replace.add(alix.inbox_id(), "alix");
replace.add(bo.inbox_id(), "bo");
  • fix duplicate messages in streams by removing drain() and improving stream all missing test
  • move commit lock from being global to existing in the client. This avoids interference with tests that use lots of clients
  • fix http-stream de-serialization errors because of a bug handling extra un-serialized bytes
  • instrument every api function

@insipx insipx requested a review from a team as a code owner February 18, 2025 20:44
@insipx insipx enabled auto-merge (squash) February 19, 2025 23:56
@insipx insipx merged commit 0a80fea into main Feb 20, 2025
15 checks passed
@insipx insipx deleted the insipx/troubleshoot-streams branch February 20, 2025 00:08
insipx added a commit that referenced this pull request Feb 20, 2025
@insipx
message stream test (#1646)
654ec28 
fix stream bugs, logging improvements

logging improvements
    allow replacing inbox id with a name (alix, bo, eve, etc) in test logs
fix duplicate messages in streams by removing drain() and improving stream all missing test
move commit lock from being global to existing in the client. This avoids interference with tests that use lots of clients
fix http-stream de-serialization errors because of a bug handling extra un-serialized bytes
instrument every api function
@insipx insipx changed the title message stream test Message Stream Test + Fixes Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insipx @nplasterer